bugfix(camera): use a distinguishable permission denied string for camera and photos #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-permissions-denied-string
…-permissions-denied-string
|
Btw: this harmonizes the behaviour for ios, since in iOS there are already two different strings too. |
…-permissions-denied-string
…-permissions-denied-string
jcesarmobile
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling
Camera.getPhotothe user is presented with an actionSheet allowing to either choose the camera or use an existing file from photos. Currently, when photos is choosen, and the user does not grant permissions, the returned error says "Unable to access camera, user denied permission request".Solution
In order to be able to distinguish, which option (camera/photos) was chosen, this PR adds an explicit error string for the case where photos permissions are not granted.