Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesystem): allow copy if from is not parent of to #546

Merged
merged 8 commits into from
Aug 23, 2021

Conversation

tachibana-shin
Copy link
Contributor

@tachibana-shin tachibana-shin commented Aug 15, 2021

Preview error:

image

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do it in a way that don't require adding external dependencies?

@tachibana-shin
Copy link
Contributor Author

I removed the dependencies. Please reconsider this request

@jcesarmobile jcesarmobile changed the title (fix: filesystem): pseudo error when running .copy "./path" -> "./path2" fix(filesystem): allow copy if from is not parent of to Aug 23, 2021
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile merged commit a70414e into ionic-team:main Aug 23, 2021
carlpoole added a commit that referenced this pull request Sep 1, 2021
* docs(browser): Add clarifications to browser events (#560)

* feat(storage): make StorageConfiguration init public (#532)

* fix(filesystem): allow copy if from is not parent of to (#546)


Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>

* fix(camera): cleanup camera images if not needed (#563)

* fix(camera): return original image if editing is cancelled (#566)

* fix(camera): return original image if editing is cancelled

* fix(camera): Fix allowEdit: true when picking from photos

* fix(camera): Resize not respecting aspect ratio on iOS (#568)

* chore: adding stuff to deploy plugins to cocoapods

* chore: adding npm install to script

* chore: updating source to point to proper tag

* chore: turning lerna concurrency to 1 for cocoapod builds

* chore(android): native library publishing task to test (#575)

* fix(local-notifications): Throw errors if missing mandatory channel fields (#577)

* fix(push-notifications): Throw errors if missing mandatory channel fields (#576)

* chore: adding manual task to deploy plugins to cocoapods

* docs(notifications): Add links to explain the Android importance and visibility values (#584)

* chore: Correct sources path in podspec (#586)

* chore: fixing action sheet podspec

* feat(geolocation): Throw error if location is disabled (#589)

* fix: Correct missing source_files path (#590)

* chore: adding full path to podspecs for cocoapods deploy (#591)

* chore(release): publish [skip ci]

 - @capacitor/action-sheet@1.0.3
 - @capacitor/app@1.0.3
 - @capacitor/app-launcher@1.0.4
 - @capacitor/browser@1.0.3
 - @capacitor/camera@1.0.5
 - @capacitor/clipboard@1.0.3
 - @capacitor/device@1.0.3
 - @capacitor/dialog@1.0.3
 - @capacitor/filesystem@1.0.3
 - @capacitor/geolocation@1.1.0
 - @capacitor/haptics@1.0.3
 - @capacitor/keyboard@1.0.3
 - @capacitor/local-notifications@1.0.5
 - @capacitor/network@1.0.3
 - @capacitor/push-notifications@1.0.4
 - @capacitor/screen-reader@1.0.3
 - @capacitor/share@1.0.4
 - @capacitor/splash-screen@1.1.2
 - @capacitor/status-bar@1.0.3
 - @capacitor/storage@1.1.0
 - @capacitor/text-zoom@1.0.3
 - @capacitor/toast@1.0.3

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: fadoscha <fabian.schaffner@gmail.com>
Co-authored-by: Tachibana Shin <45375496+tachibana-shin@users.noreply.github.com>
Co-authored-by: Max Lynch <max@drifty.com>
Co-authored-by: Ely Lucas <ely@meta-tek.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants