fix(camera): Make allowEdit work on all devices #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully on all devices, but maybe not all, I tested on android 5, 7, 9 and 11 without problems
With the move from request codes to activity launcher the code no longer catch the security exception, so now will always create a copy of the file and edit the copy instead of trying to edit the returned content urls, which could cause security exceptions in some devices.
Also calls
grantUriPermissionfor the url passed to the edit intent, shouldn't be necessary, but on Android 11 it doesn't work without it.closes #306
closes #307