Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select photos from Gallery on Samsung devices #704

Closed
Odonno opened this issue Nov 26, 2021 · 8 comments · Fixed by #706
Closed

Cannot select photos from Gallery on Samsung devices #704

Odonno opened this issue Nov 26, 2021 · 8 comments · Fixed by #706

Comments

@Odonno
Copy link

Odonno commented Nov 26, 2021

Bug Report

Plugin(s)

"@capacitor/android": "^3.3.1",
"@capacitor/app": "^1.0.6",
"@capacitor/camera": "^1.2.1",

Capacitor Version

Latest Dependencies:

@capacitor/cli: 3.3.2
@capacitor/core: 3.3.2
@capacitor/android: 3.3.2
@capacitor/ios: 3.3.2

Installed Dependencies:

@capacitor/cli: 3.3.1
@capacitor/ios: 3.3.1
@capacitor/core: 3.3.1
@capacitor/android: 3.3.1

Platform(s)

Android : Samsung Note 8

Current Behavior

When using pickImages function on a Samsung device, the gallery is opened but I cannot select image. I can see a list of images but I can only open the image in fullscreen. There is no way to select an image, even one.

Expected Behavior

Like any other gallery app, add ability to select multiple images.

Code Reproduction

Other Technical Details

Additional Context

@Odonno
Copy link
Author

Odonno commented Nov 26, 2021

Seems like the react-native team already solved a similar issue here: react-native-image-picker/react-native-image-picker#1739

@ThaierAlkhateeb
Copy link

ThaierAlkhateeb commented Nov 26, 2021

Hey,

I have got the same issue.
It shows me in console "{message: 'No images picked'}", but if I choose 'select image from Google photos app' it works.

Device: samsung SM-N960F (Android version: 10)

"@capacitor/android": "3.3.1",
"@capacitor/app": "^1.0.5",
"@capacitor/camera": "^1.2.0",
"@capacitor/core": "^3.3.1",
"@capacitor/cli": "^3.3.1"

@raykin
Copy link

raykin commented Nov 29, 2021

Totally same issue on OPPO phone. I captured several screenshots of adb logs. I can upload them if it can help to locate issues.
Updates: pickImages works fine on API29 simulator.

@carlpoole
Copy link
Member

I was able to confirm that multi-selecting is working when the Google Photos app is used as the source, but running into issues with the device/manufacturer gallery apps. I was testing the solution proposed #706 but I was still running into issues with the picker that displayed (see: #706 (comment)) and I was curious if this was the same experience on other devices. I was testing it on a Samsung Galaxy S9+ running Android 10

@carlpoole
Copy link
Member

In the case with my test on my Galaxy S9+, single tapping an image caused it to immediately try and return that image to the app, instead of allowing me to select more and then confirm. The presence of only a single image causes the processPickedImages method to fail at the moment.

To select multiple images I had to press and hold in the device picker, and then it would let me choose more and confirm. This leads me to think we could modify the multi-select code to allow the return of single images and leave it to the users to make sure they are using the device picker correctly to pick multiple images vs. a single image.

@N0ctural
Copy link
Contributor

N0ctural commented Dec 3, 2021

In the case with my test on my Galaxy S9+, single tapping an image caused it to immediately try and return that image to the app, instead of allowing me to select more and then confirm. The presence of only a single image causes the processPickedImages method to fail at the moment.

To select multiple images I had to press and hold in the device picker, and then it would let me choose more and confirm. This leads me to think we could modify the multi-select code to allow the return of single images and leave it to the users to make sure they are using the device picker correctly to pick multiple images vs. a single image.

Hello @carlpoole, I made an update on my PR to correct problem on Huawei / Oppo etc. on Android 9 with default gallery app and on Samsung devices.

@braincomb
Copy link

braincomb commented Jan 12, 2022

I can confirm I have the same issue with Samsung Gallery app on S8. There is no option or ability to select one or multiple images, tapping on an image would return No images picked error. Long-holding the finger on the image does nothing.

Running "@capacitor/camera": "^1.2.0" and npx cap doctor is below:

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 3.3.4
  @capacitor/core: 3.3.4
  @capacitor/android: 3.3.4
  @capacitor/ios: 3.3.4

Installed Dependencies:

  @capacitor/cli: 3.3.4
  @capacitor/core: 3.3.4
  @capacitor/android: 3.3.4
  @capacitor/ios: 3.3.4

[success] Android looking great! 👌

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 30, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants