fix(cli): Avoid duplicate usesCleartextTraffic attribute (#3245)

ionic-team · Jul 13, 2020 · 861874f · 861874f
1 parent 3c64162
commit 861874f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cli/src/cordova.ts b/cli/src/cordova.ts
@@ -413,12 +413,13 @@ export async function writeCordovaAndroidManifest(cordovaPlugins: Plugin[], conf
       }
     });
   });
-  let cleartext = config.app.extConfig.server?.cleartext ? 'android:usesCleartextTraffic="true"' : '';
+  let cleartextString = 'android:usesCleartextTraffic="true"';
+  let cleartext = config.app.extConfig.server?.cleartext && !applicationXMLAttributes.includes(cleartextString) ? cleartextString : '';
   let content = `<?xml version='1.0' encoding='utf-8'?>
 <manifest package="capacitor.android.plugins"
 xmlns:android="http://schemas.android.com/apk/res/android"
 xmlns:amazon="http://schemas.amazon.com/apk/res/android">
-<application ${applicationXMLAttributes.join('\n')}${cleartext}>
+<application ${applicationXMLAttributes.join('\n')} ${cleartext}>
 ${applicationXMLEntries.join('\n')}
 </application>
 ${rootXMLEntries.join('\n')}