Test JSObject

[imjacobclark]

First contribution here...

I plan on contributing more than these tests in this PR, but I chose JSObject as a first good place to start.

Feedback/thoughts welcome!

Thanks

[smpeters]

Thanks for this! I've been a bit concerned with the lack of tests in the Capacitor code so it'd be great to have some.

[smpeters]

I'm not sure this is needed. The only import the test code has that uses this is import org.json.JSONException; and that's included in Android API.

[imjacobclark]

This is needed to prevent java.lang.RuntimeException: Method getString in org.json.JSONObject not mocked. See http://g.co/androidstudio/not-mocked for details. errors as JSON is bundled with Android and thus hitting a stub, so a real JSON implementation is needed to drive a real valuable test.

[smpeters]

OK, that explanation is fine with me.

[imhoffd]

@imjacobclark Any comment on the above review? Also, this repo uses GitHub Actions, would you be able to update the PR?

[imjacobclark]

@imjacobclark Any comment on the above review? Also, this repo uses GitHub Actions, would you be able to update the PR?

Hey @dwieeb @smpeters thanks for the review - it’s on my todo list to fix this up, I’ll get around to it tomorrow I think!

[imjacobclark]

@dwieeb @smpeters resolved the static imports, updated GitHub actions, however left a comment on the outstanding requested change, as I believe that is still required!

Thanks

[imhoffd]

LGTM! Thanks for getting Capacitor set up with testing in Java. 😅

[imjacobclark]

LGTM! Thanks for getting Capacitor set up with testing in Java. 😅

@dwieeb no problem! What’s the process to get this merged in?

[imhoffd]

Couple things yet...

@smpeters Would you care to comment further or resolve the conversation in your review?
@carlpoole Care to take a look?

[smpeters]

Couple things yet...

@smpeters Would you care to comment further or resolve the conversation in your review?
@carlpoole Care to take a look?

LGTM