Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase-guide): update guide with Capacitor 2.0 changes #2598

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

jcesarmobile
Copy link
Member

Capacitor 2.0 requires to call requestPermission to prompt the user, change the guide code to use it before registering.

Also update some Ionic CLI changes since the guide was created.

Add a missing } on the full page example

@jcesarmobile jcesarmobile merged commit 4f0e749 into ionic-team:master Mar 18, 2020
@jcesarmobile jcesarmobile deleted the update-firebase-docs branch March 18, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant