Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(camera): make prompt strings localizable #2631

Merged
merged 2 commits into from
Apr 30, 2020
Merged

feat(camera): make prompt strings localizable #2631

merged 2 commits into from
Apr 30, 2020

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Mar 25, 2020 •
edited
Loading

Now, Prompt message in camera plugin is hard coding.

スクリーンショット 2020-03-25 22 21 19

I think this be able to change users label is better.
Thanks.

@rdlabo
Copy link
Contributor Author

rdlabo commented Apr 6, 2020

@jcesarmobile Can you review this pull request?? This is important user interface for user in non-English area. Thanks.

@jcesarmobile jcesarmobile self-requested a review April 30, 2020 16:41
jcesarmobile
jcesarmobile approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a small change, other than that looks good, will merge once tests finish

@jcesarmobile jcesarmobile mentioned this pull request Apr 30, 2020
Closed
@jcesarmobile jcesarmobile changed the title feat(camera): change label to be able set feat(camera): make prompt strings localizable Apr 30, 2020
@jcesarmobile jcesarmobile mentioned this pull request Apr 30, 2020
Closed
@jcesarmobile jcesarmobile merged commit 0c09fc8 into ionic-team:master Apr 30, 2020
@sandstrom sandstrom mentioned this pull request May 4, 2020
Closed
@kamekaioken kamekaioken mentioned this pull request Sep 25, 2020
Closed
@user080975 user080975 mentioned this pull request Jan 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdlabo @jcesarmobile