Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ce-plugins): Add capacitor-dark-mode plugin #2681

Merged
merged 1 commit into from
Apr 3, 2020
Merged

docs(ce-plugins): Add capacitor-dark-mode plugin #2681

merged 1 commit into from
Apr 3, 2020

Conversation

hinddeep
Copy link
Contributor

@hinddeep hinddeep commented Apr 2, 2020

I have written a capacitor plugin that enables the webview to listen for dark mode change events on Android, Web/PWA and electron. I'll be adding iOS support soon. Using this plugin apps can toggle its dark theme as soon as the platform's dark theme changes.

I have written a capacitor plugin that enables the webview to listen for dark mode change events on Android, Web/PWA and electron. I'll be adding iOS support soon. Using this plugin apps can toggle its dark theme as soon as the platform's dark theme changes.
@jcesarmobile
Copy link
Member

the github repository only have a readme, not the actual code, you should publish the real plugin

@hinddeep
Copy link
Contributor Author

hinddeep commented Apr 3, 2020

Uploaded the real plugin.

@jcesarmobile jcesarmobile changed the title Update plugins.md docs(ce-plugins): Add capacitor-dark-mode plugin Apr 3, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good!

@jcesarmobile jcesarmobile merged commit 4fcb725 into ionic-team:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants