Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): implement selection haptic feedback #2704

Merged
merged 1 commit into from
May 1, 2020
Merged

feat(android): implement selection haptic feedback #2704

merged 1 commit into from
May 1, 2020

Conversation

sbannigan
Copy link
Contributor

Implements selection haptic feedback for android.

jcesarmobile
jcesarmobile approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TEXT_HANDLE_MOVE makes more sense that CLOCK_TICK, but it's SDK 27+ and doesn't seem to work on my Android 9 phone, so better CLOCK_TICK than nothing. Thanks for the PR

@jcesarmobile jcesarmobile changed the title feat(android/haptics): implement selection haptic feedback feat(android): implement selection haptic feedback May 1, 2020
@jcesarmobile jcesarmobile merged commit 34dd280 into master May 1, 2020
@jcesarmobile jcesarmobile deleted the feat/android-haptic-selection branch May 1, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbannigan @jcesarmobile