Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use appName as package.json name on electron project #2741

Merged
merged 6 commits into from Apr 10, 2020
Merged

fix(cli): use appName as package.json name on electron project #2741

merged 6 commits into from Apr 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2020 •
edited by jcesarmobile
Loading

closes #2604

@IT-MikeS
Update Electron Add CLI
50a1773 
Update to address issue #2604 around the copying of the appName from capacitor.config.json to package.json in Electron projects.
@jcesarmobile jcesarmobile self-requested a review April 10, 2020 11:18
@jcesarmobile jcesarmobile changed the title Update Electron Add CLI fix(cli): use appName as package.json name on electron project Apr 10, 2020
jcesarmobile
jcesarmobile requested changes Apr 10, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a few changes

cli/src/electron/add.ts Outdated Show resolved Hide resolved
cli/src/electron/add.ts Outdated Show resolved Hide resolved
cli/src/electron/add.ts Outdated Show resolved Hide resolved
cli/src/electron/add.ts Outdated Show resolved Hide resolved
cli/src/electron/add.ts Outdated Show resolved Hide resolved
Mike S and others added 5 commits April 10, 2020 12:25
@jcesarmobile
Update cli/src/electron/add.ts
c09241f 
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@jcesarmobile
Update cli/src/electron/add.ts
948baab 
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@jcesarmobile
Update cli/src/electron/add.ts
221344a 
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@jcesarmobile
Update cli/src/electron/add.ts
11c6fcc 
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@jcesarmobile
Update cli/src/electron/add.ts
866acb4 
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
@jcesarmobile jcesarmobile merged commit d6fc2d8 into ionic-team:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: name and description parameters for npx cap add electron
2 participants
@jcesarmobile @IT-MikeS