Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): Update Modals Plugin to use new dialog async syntax #2742

Merged
merged 1 commit into from Apr 10, 2020
Merged

fix(electron): Update Modals Plugin to use new dialog async syntax #2742

merged 1 commit into from Apr 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2020 •
edited by jcesarmobile
Loading

closes #2693

@IT-MikeS
Update Electron Modal Plugin
686534e 
Update to address issue #2693 around Electron’s dialog spec being changed.
@jcesarmobile jcesarmobile self-requested a review April 10, 2020 11:52
jcesarmobile
jcesarmobile approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

For next PRs, if it fixes an existing issue, can you use "fixes #number" "closes #number" or similar github syntax that allows to auto close issues on merge?

@jcesarmobile jcesarmobile changed the title Update Electron Modal Plugin fix(electron): Update Modals Plugin to use new dialog async syntax Apr 10, 2020
@jcesarmobile jcesarmobile merged commit 4c13fe0 into ionic-team:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Plugins.Modals.confirm in electron doesnt awaits for response
2 participants
@jcesarmobile @IT-MikeS