Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(browser): Updated information for close method #2796

Merged
merged 1 commit into from
Apr 30, 2020
Merged

docs(browser): Updated information for close method #2796

merged 1 commit into from
Apr 30, 2020

Conversation

pgerhard
Copy link
Contributor

Closes #2779

jcesarmobile
jcesarmobile requested changes Apr 29, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you commit only the core/src/core-plugin-definitions.ts file?

The other ones are generated and we should probably add them to the gitignore.

@jcesarmobile jcesarmobile changed the title Updated documentation for BrowserPlugin close method. docs(browser): Updated information for close method Apr 29, 2020
@pgerhard pgerhard force-pushed the 2779UpdatedBrowserPluginDocumentation branch from 2199de0 to 36a6f38 Compare April 30, 2020 09:37
@pgerhard
Copy link
Contributor Author

@jcesarmobile Done

jcesarmobile
jcesarmobile approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jcesarmobile jcesarmobile merged commit 89c64af into ionic-team:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Inaccurate documentation for Browser Plugin
2 participants
@pgerhard @jcesarmobile