Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set launchShowDuration to 0 on new projects only #2876

Merged

Conversation

jcesarmobile
Copy link
Member

Instead of setting the default native value to 0 as done on b29346b

set the default values back to 3000 and make new projects have

"plugins": {
    "SplashScreen": {
        "launchShowDuration": 0
    }
}

@imhoffd
Copy link
Contributor

imhoffd commented May 6, 2020

Should it just be showDuration to match the plugin options at runtime?

image

@jcesarmobile
Copy link
Member Author

jcesarmobile commented May 6, 2020

It was called launchShowDuration as it's only applied on the launch of the app, while showDuration is for API calls to show method.
We can't change the name now, it's an existing preference.

@jcesarmobile jcesarmobile merged commit 8de0414 into ionic-team:master May 7, 2020
@jcesarmobile jcesarmobile deleted the launchShowDuration-new branch May 7, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants