Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify ios publishing #3028

Merged

Conversation

jcesarmobile
Copy link
Member

the publish script was creating a capacitor-ios folder and moving ios files inside before publishing to npm

since we no longer need the Capacitor.podspec and CapacitorCordova.podspec in the root of the repository, they can be moved to the iOS folder, so we can remove the templates we use for injecting the version, same for the package.json.template.

This will allow users to install ios platform from a local folder, it has been requested by users and wasn't possible because of all this file copying.

@jcesarmobile jcesarmobile requested a review from imhoffd June 1, 2020 19:20
@imhoffd
Copy link
Contributor

imhoffd commented Jun 1, 2020

😍

@jcesarmobile jcesarmobile merged commit 38791a8 into ionic-team:master Jun 2, 2020
@jcesarmobile jcesarmobile deleted the ios-publish-simplification branch June 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants