Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/cordova): replace $PACKAGE_NAME with ${applicationId} #3030

Merged
merged 2 commits into from
Jun 10, 2020
Merged

fix(cli/cordova): replace $PACKAGE_NAME with ${applicationId} #3030

merged 2 commits into from
Jun 10, 2020

Conversation

robingenz
Copy link
Contributor

Fix #3026

@robingenz robingenz mentioned this pull request Jun 1, 2020
Closed
4 tasks
@jcesarmobile jcesarmobile changed the title fix: replace $PACKAGE_NAME with ${applicationId} fix(cli/android): replace $PACKAGE_NAME with ${applicationId} Jun 10, 2020
@jcesarmobile jcesarmobile changed the title fix(cli/android): replace $PACKAGE_NAME with ${applicationId} fix(cli/cordova): replace $PACKAGE_NAME with ${applicationId} Jun 10, 2020
@jcesarmobile jcesarmobile merged commit 7a2a45f into ionic-team:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Android build variables are replaced during sync
2 participants
@robingenz @jcesarmobile