Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios/keyboard): update frame immediately when keyboard hides #3038

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

sbannigan
Copy link
Contributor

Currently, when the keyboard hides, if the user is scrolling in the webview the keyboardWillHide event won't fire and the frame won't update until the scrolling stops. See this app that hides the keyboard when scrolling starts:

Current Behavior:
ezgif com-video-to-gif

Fixed Behavior:
ezgif com-video-to-gif (1)

@jcesarmobile
Copy link
Member

can you provide a sample app where the issue can be reproduced?

@sbannigan
Copy link
Contributor Author

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile merged commit e538bad into master Jun 3, 2020
@jcesarmobile jcesarmobile deleted the fix/ios-keyboard-hide-delay branch June 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants