Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): LocalNotification action not dismissing notification #3112

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

jcesarmobile
Copy link
Member

I've noticed some actions are not dismissing the notification when you choose an action, all of them should, so removing the check.

@jcesarmobile jcesarmobile merged commit 6f5504b into ionic-team:master Jun 16, 2020
@jcesarmobile jcesarmobile deleted the dismiss-on-action branch June 16, 2020 11:48
@tomkahn
Copy link

tomkahn commented Oct 22, 2020

@jcesarmobile Shouldn't the notification only be dismissed when either "destructive" (of the LocalNotificationAction) or "autoCancel" (of the LocalNotification) is set to true? That's how I thought it would work from reading the documentation. At the moment it seems that no matter what I set for these props, the notification is always dismissed when I tap on it or on one of its buttons. The app is also always brought to the foreground (ignoring foreground: false). I only tested this on Android 9 & 10, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants