Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "missing web assets directory" error message #3131

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

dotNetkow
Copy link
Contributor

@dotNetkow dotNetkow commented Jun 22, 2020

Update the error message displayed when a user tries to add a native platform to their project, before having built their web code.

Changes:

  • Fix the More Info link to point to the correct page (/basics/building-your-app instead of /basics/configuring-your-app).
  • Help the user by telling them which property to change in capacitor config (webDir).
  • Added build details for both Ionic apps and non-Ionic apps.

Wasn't sure how to format correctly for newlines - this function doesn't use log("") like the others.

@imhoffd
Copy link
Contributor

imhoffd commented Jun 22, 2020

It's using template literals. Newlines are printed as-in onto the screen. It actually preserves your spaces too so it prints kinda weird, like this:

Capacitor could not find the web assets directory "./www".
    Please create it and make sure it has an index.html file. You can change
    the path of this directory in capacitor.config.json (webDir option). You may need ...

@imhoffd imhoffd merged commit da8b8a0 into master Jun 22, 2020
@imhoffd imhoffd deleted the messaging-web-assets branch June 22, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants