fix(cordova): patch usages of webView superview #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins use
[self.webView superview](cordova-plugin-camera), orself.webView.superview(cordova-plugin-camera-preview), and probably others.In Capacitor the webView is the top most view, so there is no superview and makes the plugins to not work or crash.
By replacing those usages to
self.viewController.view, cordova-plugin-camera is able to present popovers, and cordova-plugin-camera-preview is able to show the camera preview (only over the html, not behind it as in cordova, but it's better than crashing).closes #3176
related cordova-plugin-camera-preview issue that was closed as incompatible: #1732