Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): STUDIO_PATH environment variable #3755

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Nov 2, 2020

This is a breaking change that removes the windowsAndroidStudioPath and linuxAndroidStudioPath configuration options, combining them into a STUDIO_PATH environment variable, which can be set on any OS.

The naming style of STUDIO_PATH comes from other Android Studio environment variables: https://developer.android.com/studio/command-line/variables

addresses #230 and #2493

@imhoffd imhoffd added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Nov 3, 2020
@imhoffd imhoffd added this to the 3.0.0 milestone Nov 3, 2020
@imhoffd imhoffd moved this from In progress 🤺 to Needs review 🤔 in Capacitor Engineering ⚡️ Nov 3, 2020
@jcesarmobile
Copy link
Member

Wasn’t the point of config.js/ts point to be able to use env variables within the files? That would make this PR redundant without the need to use an environment variable of our own

@imhoffd
Copy link
Contributor Author

imhoffd commented Nov 3, 2020

This change is addressing the following in the config file proposal:

Android Studio path (and other system paths) should not be a part of the Capacitor config because it is the configuration of the app and not for system settings.

@imhoffd imhoffd merged commit 65cef53 into main Nov 3, 2020
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Nov 3, 2020
@imhoffd imhoffd deleted the android-studio-path branch November 3, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants