fix(iOS): skip Swift type coercion on Cordova plugin calls #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… otherwise it can break Cordova calls by stripping out NSNull values.
jcesarmobile
approved these changes
Jan 12, 2021
imhoffd
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch moves the point at which the
JSCalloptions are coerced into the preferred swift types. The coercion stripsNSNullobjects, which is an Obj-C placeholder fornilin collections. Removing the object(s) changes the indexes of arguments on Cordova calls and breaks existing behavior. The coercion is moved from theJSCallwrapper (which is used for both types of plugins) to the point where theCAPPluginCallis created for Capacitor plugins.