Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add configurable app path for embedded capacitor #4264

Merged
merged 8 commits into from
Mar 3, 2021

Conversation

carlpoole
Copy link
Member

This PR adds a configurable path string to load a specific initial path for a Capacitor app.

See #3405 and #4157

Example usage:

BridgeFragment embeddedFragment = BridgeFragment.newInstance("app1");
CapConfig config = new CapConfig.Builder(this)
            .setPath("/feature_1")
            .create();
        
embeddedFragment.setConfig(config);

@carlpoole carlpoole added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Mar 1, 2021
@carlpoole carlpoole self-assigned this Mar 1, 2021
@carlpoole carlpoole moved this from In progress 🤺 to Needs review 🤔 in Capacitor Engineering ⚡️ Mar 1, 2021
@carlpoole carlpoole added this to the 3.0.0-rc milestone Mar 3, 2021
@carlpoole carlpoole merged commit e433691 into main Mar 3, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Mar 3, 2021
@carlpoole carlpoole deleted the android-path branch March 3, 2021 19:22
@fkirc
Copy link
Contributor

fkirc commented Mar 12, 2021

Thanks for implementing this much-needed feature!
I will migrate to V3 as soon as those runtime-paths are working for both Android and iOS.
Until now, I was using a path-redirect-workaround via a custom plugin, but this path-redirect-workaround was only working after an initial rendering of my embedded web-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants