fix(android): Release the call after reject/resolve #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this not regress this fix if the call is saved again before it is resolved? #4281 |
|
I tried and doesn't look like it, if the call is saved again, since it's the same call, with same id, and savedCalls is a |
|
I understand this now. I do like this a lot better. So basically the life of the call lasts until it is resolved/rejected (aka finished) and if you want the call to last past that, use the keepAlive setting. And it works because the call isn't resolved until the native work has been completed - which can last through multiple intents. |
carlpoole
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capacitor calls are being saved when an intent is being launched and then released after the intent returns a result, but before the plugin returns the result, and in cases where there are multiple intents launched by the same plugin call it ends up creating null pointer exceptions in some cases where the call was released sooner than expected and needed later.
This PR removes the early releases of the calls and put it where the call actually rejects or resolves to the JS side.
closes #4307