Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Use web listener if there is no native implementation #4488

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

jcesarmobile
Copy link
Member

Instead of always using the native listener on the native platforms, check if the native platform has a native implementation for the plugin (if pluginHeader is defined), and if not, use the web listener.

closes #4331

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Apr 23, 2021
@jcesarmobile jcesarmobile merged commit 196d843 into main Apr 26, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Apr 26, 2021
@jcesarmobile jcesarmobile deleted the use-web-no-headers branch April 26, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

bug: web only plugins don't fire listeners on native apps
2 participants