Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): Safely JSON.Stringify circular json on log #4507

Merged
merged 8 commits into from
May 6, 2021

Conversation

bazuka5801
Copy link
Contributor

Fix #4506

@thomasvidas thomasvidas changed the title fix: logger throw StackOveflow exception fix(bridge): Safely JSON.Stringify circular json on log May 3, 2021
Copy link
Contributor

@thomasvidas thomasvidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use safeStringify rather than JSON.stringify on line 374 and line 404 as well? Otherwise this seems fine 👍

@thomasvidas thomasvidas merged commit e4c8fe4 into ionic-team:main May 6, 2021
@thomasvidas
Copy link
Contributor

Temporarily reverting this because of linting issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: infinite loop on console error using quasar framework
2 participants