Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Throw error if native-run didn't find targets #4681

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

jcesarmobile
Copy link
Member

At the moment if native-run didn't find any device or emulator, run just silently fail.

This PR changes the behavior to throw the errors (can be more than one) that native-run provided.

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Jun 4, 2021
@jcesarmobile jcesarmobile merged commit bfbf2b5 into main Jun 7, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jun 7, 2021
@jcesarmobile jcesarmobile deleted the native-run-errors branch June 7, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants