fix(cli): Put cordova git pod dependencies in Podfile #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvidas
approved these changes
Aug 18, 2021
elylucas
pushed a commit
that referenced
this pull request
Aug 24, 2021
This was referenced Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Cordova plugins are using pod dependencies directly from GitHub, as they don't have a version we just add a dependency in the podspec, but if it's not published in CocoaPods repo Capacitor won't find it.
This PR will read pod entries in plugin.xml and if they are git references it will put them in the users Podfile with the other Capacitor dependencies so it can be found.
closes #4867