Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): proguard rules #5048

Merged
merged 4 commits into from
Sep 14, 2021
Merged

fix(android): proguard rules #5048

merged 4 commits into from
Sep 14, 2021

Conversation

carlpoole
Copy link
Member

Adds Proguard rules to the Capacitor Android project, suggested by @Zapominacz
#4780

The rules will be effective when minifyEnabled is set to true on the application project

Resolves #739

@carlpoole carlpoole self-assigned this Sep 13, 2021
@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Sep 13, 2021
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

not sure if this is really a feature, or just a fix for #739

@carlpoole carlpoole changed the title feat(android): proguard rules fix(android): proguard rules Sep 14, 2021
@carlpoole carlpoole merged commit cf15c0f into main Sep 14, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Sep 14, 2021
@carlpoole carlpoole deleted the proguard-rules branch September 14, 2021 14:56
elylucas pushed a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Issues in release build when minifyEnabled is set to true
3 participants