feat(android): Use addWebMessageListener where available #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
changed the title
jcesarmobile
requested review from
giralte-ionic,
IT-MikeS,
ItsChaceD and
theproducer
IT-MikeS
approved these changes
Jul 19, 2022
giralte-ionic
approved these changes
Jul 19, 2022
|
did a minor change to use a lambda that simplifies the code |
carlpoole
approved these changes
Jul 19, 2022
giralte-ionic
approved these changes
Jul 19, 2022
IT-MikeS
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use the
addWebMessageListenerAPI if available, if not it will default to the old bridge.I made that the bridge is injected to the capacitor default url (i.e. http://localhost), to
server.urlif configured, and also to all the urls inserver.allowNavigation.Also only passes the message to the js side if it's the main frame.