feat(ios): add getConfig to CAPPlugin #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Mar 10, 2022
There was a problem hiding this comment.
The idea is to do something like what was done for Android here 9820a30
To have a PluginConfig class with helper methods to get strings, ints, etc. and the new getConfig should return that class with the config for that plugin only, not the whole configuration, as that's already accesible from the bridge.
jcesarmobile
requested changes
Mar 11, 2022
There was a problem hiding this comment.
getArray on Android has 2 functions, one with default and another without it, here it's missing the without default option
run npm run fmt as swift files have a bunch of ; at the end on swift files that not sure why the lint is not complaining about them, but fmt removes them.
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
|
adjusted in latest commit |
jcesarmobile
approved these changes
Mar 14, 2022
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5476