fix(android): move initialFocus on webview into config #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Apr 29, 2022
There was a problem hiding this comment.
Despite the main purpose of this configuration is to be used in Portals, I think it still should be included in the CLI declarations so it can be configured from typescript too
Thank you, good catch. This was the intention but I missed it. I added it now |
Steven0351
reviewed
Apr 29, 2022
Steven0351
approved these changes
Apr 29, 2022
jcesarmobile
approved these changes
May 2, 2022
This was referenced Jun 1, 2022
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the initial focus action of the webview on Android into a config flag which is
trueby default for Capacitor proper, andfalseby default for programmatic setup (i.e: Portals) where we may not want the webview to have the initial focus.This line causes some problems on Portals apps by causing the webview to be selected when a page loads, and this may not be desired. With it being a config property, a developer could still enable it at any time if preferred. Portals apps will be configured to set this property to false by default.