feat(cli): Option to inline JS source maps during sync #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
jcesarmobile,
ItsChaceD,
IT-MikeS,
dtarnawsky and
giralte-ionic
IT-MikeS
approved these changes
Aug 8, 2022
dtarnawsky
reviewed
Aug 9, 2022
cli/src/tasks/sourcemaps.ts
Outdated
| import type { Config } from '../definitions'; | ||
| import { logger } from '../log'; | ||
|
|
||
| function findJSAssetsDir(buildDir: string): string { |
There was a problem hiding this comment.
JS files could be any folder. Im not sure you would want to hard code this for React and Vue.
dtarnawsky
reviewed
Aug 9, 2022
cli/src/tasks/sourcemaps.ts
Outdated
|
|
||
| function findJSAssetsDir(buildDir: string): string { | ||
| const reactJSDir = '/static/js'; | ||
| const vueJSDir = '/js'; |
There was a problem hiding this comment.
Path.join is required for folder separators which will change based on platform (eg on windows its \ rather than /)
dtarnawsky
reviewed
Aug 9, 2022
giralte-ionic
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the
synccommand ,--inline, which will, after syncing, inline all JS source maps for easier debugging on mobile devices.