Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): proper plugin module patch in monorepos #6589

Merged
merged 2 commits into from May 12, 2023
Merged

fix(cli): proper plugin module patch in monorepos #6589

merged 2 commits into from May 12, 2023

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented May 12, 2023 •
edited

use resolveNode to get the proper node_modules path instead of hardcoding to node_modules so it works in monorepo setups

closes #6588

@jcesarmobile jcesarmobile merged commit d49e632 into main May 12, 2023
6 checks passed
@jcesarmobile jcesarmobile deleted the monorepo-migrate branch May 12, 2023 15:30
@jcesarmobile jcesarmobile mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markemer markemer markemer approved these changes

@IT-MikeS IT-MikeS IT-MikeS approved these changes

@theproducer theproducer Awaiting requested review from theproducer

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@giralte-ionic giralte-ionic Awaiting requested review from giralte-ionic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Android build graddle issues when Going from 5.0.1 to 5.0.2
3 participants
@jcesarmobile @markemer @IT-MikeS