fix(android): Move bridge localUrl initialization to initWebView #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Jun 27, 2023
ItsChaceD
approved these changes
Jun 27, 2023
|
Testing this with Portals, I think it's okay I just want to be sure |
carlpoole
approved these changes
Jun 27, 2023
good catch, I thought about it but then forgot after pasting the line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In plugin's
load()method,getLocalUrl()is null because it's being set after the plugin initialization.I've moved the code related to the localUrl creation to the
initWebView()so it's available inload()method.Once it's merged we can revert the changes made in Cookies plugin to init the plugin after the local url is set.