fix(http): prevent POST request from being proxied #7395
Merged
+18
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
nflsilva,
ItsChaceD and
giralte-ionic
giralte-ionic
approved these changes
Apr 12, 2024
markemer
approved these changes
Apr 15, 2024
IT-MikeS
approved these changes
Apr 15, 2024
jcesarmobile
added a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Mark Anderson <mark@ionic.io> Co-authored-by: Dan Giralté <97970732+giralte-ionic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
options?.methodis undefined forPOSTrequests, so the request is being proxied, but the proxy can't handle POST data, so the data is lost.Instead of checking
options?.method, check the request'smethod, which seems to always be defined.closes #7391