fix: Use a single scheme for all files #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ionic:// for app assets and local files instead of having multiple schemes based on the file type fix ionic-team#258
|
It just work like a charm, tested on a simulated iPhone and on my Android phone in my Ionic Angular app Thx a lot @jcesarmobile you are today's real MVP 👍 |
Ionitron
added a commit
that referenced
this pull request
Jan 17, 2019
# [3.1.0](v3.0.0...v3.1.0) (2019-01-17) ### Bug Fixes * **ios:** Fix video playback of files with uppercase extension ([#264](#264)) ([2c4b225](2c4b225)), closes [#260](#260) * Set engines to require Cordova CLI 7.1.0 or newer ([#276](#276)) ([40f42e1](40f42e1)), closes [#263](#263) * Use a single scheme for all files ([#270](#270)) ([3d1bcdd](3d1bcdd)), closes [#258](#258) ### Features * **Android:** Make app Scheme configurable with a preference ([#274](#274)) ([18d9f2c](18d9f2c)), closes [#269](#269) [#255](#255)
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
So we need to use ionic://app_file/.... or ionic://app_content/.... to access these files which we get when we use Webview. convertFileSrc ? I assume there is no possibility that this will end up in v2.3 because I currently use that version to have iOS 9 support and because of issues like #266 or is this issue fixed with this PR too? |
|
Yeah, it's on 2.3.2 already, but the problem on #266 is different, it's really an angular config "problem", will document it on the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ionic:// for app assets and local files instead of having multiple schemes based on the file
type
fix #258