Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Commit

Permalink
fix(serve): if a build error occurs, return config if non-fatal
Browse files Browse the repository at this point in the history
The promise chain is restored by a .catch(), so we need to continue the
chain with the appropriate resolved value.

This should fix ionic-team/ionic-cli#2247
  • Loading branch information
imhoffd committed May 16, 2017
1 parent ce5c848 commit e5a4134
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/serve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export function serve(context: BuildContext) {
throw err;
} else {
onReady(config, context);
return config;
}
});
}
Expand Down

2 comments on commit e5a4134

@osamasoliman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit solves that problem:
[ERROR] app-scripts serve unexpectedly failed.settings: undefinedcontext: [object Object]

@gerardob
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have that problem [ERROR] app-scripts serve unexpectedly failed.settings: undefinedcontext: [object Object]
and this in the next line:
(node:10095) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: channel closed

ionic info :
global packages:

@ionic/cli-utils : 1.3.0
Cordova CLI      : 7.0.1 
Ionic CLI        : 3.3.0

local packages:

@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.3.0
@ionic/cli-plugin-ionic-angular : 1.3.0
Cordova Platforms               : none
Ionic Framework                 : ionic-angular 3.2.1

System:

Node       : v6.11.0
OS         : Linux 4.8
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

right now I have this work around "npm run ionic:serve"

Please sign in to comment.