-
Notifications
You must be signed in to change notification settings - Fork 300
Custom sass.config.js not using includePaths #541
Comments
Is this still an issue? Please let me know if it is. Thanks, |
Aplogies for commenting ona closed issue, but was there ever a solution to this? I have exactly the same issue - trying to add a 3rd party plugin styles into my Sass build (just Bootstrap for testing purposes). I've created a config file at custom-config/sass.config.js
and then run What am I doing wrong? |
@danbucholtz More than one year later, I can confirm it's still an issue. Even if you fix the issue, may I have your attention on the following related issue? I'm creating a 3rd party library for Ionic, and it seems to be the only way to have style included to the projet using it. As per documentation (https://ionicframework.com/docs/developer-resources/third-party-libs/):
I totally disagree. From what I can see, every library with style will not work without changing the build process. On a regular Angular project, there is no issue with that because we can convert styleUrls to inline styles thus CSS is part of the component. Am I doing something wrong or is there a huge issue? EDIT 02/02/2018: OK - my bad. There is no defect. We need to manually import the scss file (@edwardpayton in your case, @import 'boostrap.min') after editing the sass.config.js file. BUT, my above remarks are still valid. Including a library is too complex using Ionic. |
This is definitely still an issue. includePaths seems to be completely ignored. As of @ionic/app-scripts : 3.2.0, it seems you'll still need to @include FILE; somewhere See this closed issue on app script's github I found that as of 'Ionic Framework : ionic-angular 3.9.2' you have two choices insert your import in src/theme/variables.scss or src/app/app.scss. For example in variables.scss
@danbucholtz Is there a way to only specify an include path and have app scripts look for any .scss files regardless of whether there is an '@import' statement? @edwardpayton or @leifwells did you ever find a suitable workaround? |
Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
I needed to add some Sass files into the build that the build process wasn't finding, so I decided to copy the
sass.config.js
file into my project (like it appears in the ReadMe) and add a path to theincludePaths
node.I've attempted these paths (the last two are the path not being found):
While I can tell that the
sass.config.js
is being used (by changing theoutputFilename
), the Sass files in thesrc/theme/overrides
folder aren't getting compiled into themain.css
file.What behavior are you expecting?
I expect the CSS in the Sass files found in the
includedPaths
node to be inside mymain.css
file.Steps to reproduce:
sass.config.js
file into your projectpackage.json
file as indicated in the ReadMe file.npm run build
main.css
file.Which @ionic/app-scripts version are you using?
0.0.47
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
The text was updated successfully, but these errors were encountered: