Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Custom config does not work on Windows #58

Closed
ghost opened this issue Oct 1, 2016 · 6 comments
Closed

Custom config does not work on Windows #58

ghost opened this issue Oct 1, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Oct 1, 2016

When trying to set a custom config file for a build step on Windows (for example, rollup.config.js), it will not find the config file, even though it is there. This can be reproduced by both setting a CLI option, or using the config in package.json. It works fine in OS X. Running on Windows 10 x64.

@adamdbradley
Copy link
Contributor

Is there an error message that prints out?

@ghost
Copy link
Author

ghost commented Oct 2, 2016

It says that the config file at path cannot be found, even though it prints the correct path.

@pskhodad
Copy link

pskhodad commented Oct 2, 2016

I think message about config file not found appears to be bit misleading. In my case there was issue with custom rollup config. So custom rollup was indeed found but it errored out due to issue with config.

[23:28:36] Config file "C:\dev\pwa\roll003\config\rollup.config.js" not found. Using defaults instead.

[23:28:36] Error: Cannot find module '../dist/plugins/ng-template'

And in my custom rollup I had
var ngTemplate = require('../dist/plugins/ng-template').ngTemplate;

@ghost
Copy link
Author

ghost commented Oct 2, 2016

Oh, that might be an issue, I remember seeing something like that. I'll check when I get home. It works fine in OS X though, so I think the error should be made a bit clearer/the behavior should be reproduced. Thank you for the fix, though.

@ghost ghost closed this as completed Oct 2, 2016
@ghost
Copy link
Author

ghost commented Oct 2, 2016

Oh, that might be an issue, I remember seeing something like that. I'll check when I get home. It works fine in OS X though, so I think the error should be made a bit clearer/the behavior should be reproduced. Thank you for the fix, though.

@dmastag
Copy link

dmastag commented Oct 8, 2016

Got the same exact issue and resolved using the notes from @pskhodad to check the log.
Changed

var ngTemplate = require('../dist/plugins/ng-template').ngTemplate;

into

const ngTemplate = require('@ionic/app-scripts/dist/plugins/ng-template').ngTemplate;

and its now working properly.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants