Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ionic resources source different images for landscape and portrait #2679

Open
kyleboucherlancom opened this issue Aug 20, 2017 · 1 comment

Comments

@kyleboucherlancom
Copy link

As a feature request it would be nice if we could use a different source image for landscape and portrait.

Right now the tool crops the source image to fit for landscape and portrait, however this doesn't always produce best results with images expected to take up the full screen.

The same method of cropping can be used on different source images. This will allow the image to take up the full screen in both landscape and portrait without having black bars in one mode (or half the image cut off)

Example use case:
Portrait: An image of a tall building.
Landscape: An image of a city skyline including the tall building

Filenaming:
Currently we use splash.png.
For this feature we could have 2 files, splash-landscape.png and splash-portrait.png.

@imhoffd imhoffd added this to the CLI Future milestone Aug 29, 2017
@imhoffd
Copy link
Contributor

imhoffd commented Aug 29, 2017

Good idea. I will look into this sometime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tooling 🔧
  
Backlog 🤖
Development

No branches or pull requests

2 participants