Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic cordova wrapping swallows "Terminate batch job (Y/N)?" prompt, causing e.g. cordova run processes to not really stop and cause increasing port numbers to be used #2916

Open
janpio opened this issue Dec 10, 2017 · 3 comments

Comments

@janpio
Copy link
Contributor

janpio commented Dec 10, 2017

Compare what happens when you hit Ctrl + C when running ionic cordova run ... vs. when running cordova run ...:

On the pure cordova command you get an additional prompt:

^CTerminate batch job (Y/N)? y

When you immediately run the same command again after killing it, it should just start a server again on the same port, 8000 by default. But with ionic cordova ... you get increasing port numbers:

Running app-scripts build: --platform browser --target cordova
[23:04:40]  build dev started ...
...
[23:04:55]  build dev finished in 14.75 s
> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8001/index.html
CTRL + C to shut down
200 /index.html (gzip)
...
404 /screen
200 /build/vendor.js (gzip)
[23:05:01]  lint finished in 6.07 s
PS C:\Projects\Ionic Demo Projects\browserTest2> ionic cordova run browser
Running app-scripts build: --platform browser --target cordova
[23:05:19]  build dev started ...
...
[23:05:34]  build dev finished in 14.90 s
> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8002/index.html
CTRL + C to shut down
200 /index.html (gzip)
...
404 /screen

vs.

PS C:\Projects\Ionic Demo Projects\browserTest2> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8000/index.html
CTRL + C to shut down
200 /index.html (gzip)
...
404 /screen
^CTerminate batch job (Y/N)?
^C
PS C:\Projects\Ionic Demo Projects\browserTest2> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8000/index.html
CTRL + C to shut down
304 /index.html
...
404 /screen

That this "Terminate batch job" prompt is important can be deduced from what happens when you first run ionic cordova run with increasing port numbers, then cordova run once with another +1 port and kill it with the prompt, after that the next run will get the initial port number again:

...
PS C:\Projects\Ionic Demo Projects\browserTest2> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8003/index.html
CTRL + C to shut down...
^CTerminate batch job (Y/N)?
^CThe system cannot open the device or file specified.
PS C:\Projects\Ionic Demo Projects\browserTest2> cordova run browser
startPage = index.html
Static file server running @ http://localhost:8000/index.html
CTRL + C to shut down
...

PS: Found via StackOverflow question https://stackoverflow.com/q/47737515/252627

@janpio janpio changed the title ionic cordova wrapping swallows "Terminate batch job (Y/N)?" prompt, causing e.g. cordova run processes to not really stop ionic cordova wrapping swallows "Terminate batch job (Y/N)?" prompt, causing e.g. cordova run processes to not really stop and cause increasing port numbers to be used Dec 10, 2017
@imhoffd
Copy link
Contributor

imhoffd commented Jan 8, 2018

Is this just cordova run browser?

This is not our output:

Static file server running @ http://localhost:8000/index.html
CTRL + C to shut down

@janpio
Copy link
Contributor Author

janpio commented Jan 8, 2018

Good point. Will look into that.

@janpio
Copy link
Contributor Author

janpio commented Jan 8, 2018

Yep. So if you don't care about cordova-browser, you don't care about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants