fix(appflow): fix deploy manifest for Capacitor 1.x apps #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capacitor 2.x apps would throw a status code of 1 with
capacitor config --jsonand theoutputvariable in this case would be undefined. However, on Capacitor 1.x apps this results in a status code of 0 and theoutputvariable is populated with text that we weren't expecting. This change will ensure that the output of that command can be parsed into JSON, in which we should reliably know that the user is using Capacitor 3.x and that we can retrieve their config from this command while supporting Capacitor 1.x and 2.x as well.