feat(appflow): deprecate appflow functionality in @ionic/cli #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smzelek
force-pushed
the
CT-958_deprecate_ionic_cli_for_appflow
branch
3 times, most recently
from
94ef0ad
to
6992765
Compare
jlane9
reviewed
Oct 18, 2021
| @@ -77,6 +77,13 @@ export async function runUpdateCheck({ config }: PersistPackageVersionsDeps): Pr | |||
| await writeUpdateConfig(dir, newUpdateConfig); | |||
| } | |||
|
|
|||
| export const IONIC_CLOUD_CLI_MIGRATION = () => | |||
There was a problem hiding this comment.
Does this really need to be a function?
There was a problem hiding this comment.
No, it just made the formatting easier to read for free is all.
There was a problem hiding this comment.
Maybe just turn it into an IIFE: https://developer.mozilla.org/en-US/docs/Glossary/IIFE
giocalitri
approved these changes
Oct 19, 2021
smzelek
force-pushed
the
CT-958_deprecate_ionic_cli_for_appflow
branch
from
6992765
to
6022b39
Compare
jaredhagen
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.