Skip to content
This repository has been archived by the owner on Apr 2, 2018. It is now read-only.

Push imports complete RxJS library #52

Open
procrafts opened this issue Apr 29, 2017 · 1 comment
Open

Push imports complete RxJS library #52

procrafts opened this issue Apr 29, 2017 · 1 comment

Comments

@procrafts
Copy link

Contrary to the suggestion from RxJS, this module imports the complete RxJS library. It should only import the parts that are used as explained here: https://github.com/ReactiveX/rxjs

I noticed it because I could use all operators from RxJS in my Ionic 3 app without importing them. The only import from RxJS I used in my app was:
import { Observable } from 'rxjs/Observable';

After I commented out the following imports, I got errors because of the missing imports of used RxJS operators:

import { CloudModule, CloudSettings } from '@ionic/cloud-angular';
import { Push, PushToken } from '@ionic/cloud-angular';

I installed the following dependency:
"@ionic/cloud-angular": "0.12.0"
and found in
node_modules/@ionic/cloud-angular/dist/es5/index.js
the following line 22
var rxjs_1 = require("rxjs");
and in
node_modules/@ionic/cloud-angular/dist/esm/index.js
the line 18
import { Observable } from 'rxjs';

I think it should work, if the first line is
var rxjs_1 = require("rxjs/Observable");
and the other line is
import { Observable } from 'rxjs/Observable';

I would be grateful, if somebody could fix this.

@procrafts
Copy link
Author

#48 could solve this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant