Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GoogleMaps to the v4 api list page #2658

Closed
wf9a5m75 opened this issue Aug 25, 2018 · 15 comments · Fixed by ionic-team/ionic-docs#383
Closed

Add GoogleMaps to the v4 api list page #2658

wf9a5m75 opened this issue Aug 25, 2018 · 15 comments · Fixed by ionic-team/ionic-docs#383

Comments

@wf9a5m75
Copy link
Contributor

Please add @ionic-native/google-maps to https://beta.ionicframework.com/docs/native page.

@ionic-native/google-maps v5.0.0-beta works on ionic v4

@wf9a5m75
Copy link
Contributor Author

@mlynch ping

@perrygovier
Copy link
Contributor

perrygovier commented Aug 27, 2018

Hey @wf9a5m75, the maintainer of that plugin decided to build their plugin in an entirely different repo, so our documentation scripts don't see it. It's on our todo list to add some special scripts to make sure it's included. For the beta launch we were more focused on the plugins in this repo.

@wf9a5m75
Copy link
Contributor Author

the maintainer of that plugin decided is me.

The reason of this is the ionic team does not maintenance the wrapper plugin well.
If I sent a new pull request, you left almost 2 months. That's why I got angry, then divided to different repo.
If you guarantee to manage well, I don't need to manage the wrapper plugin.

I don't ask any difficult thing. I just ask please add a link to the google maps repo, like this page.
https://ionicframework.com/docs/native/

Is this super difficult?

@wf9a5m75
Copy link
Contributor Author

I guess you just modify this script.
https://github.com/ionic-team/ionic-native/blob/v5/scripts/docs/dgeni/processors/jekyll.js

Should I send a pull request if difficult work?

@wf9a5m75
Copy link
Contributor Author

@perrygovier Any comments?

@wf9a5m75
Copy link
Contributor Author

Ok, if Ionic team does not help me, I won't help you. Starting from now until you work, I will decline any issues for the ionic-native/google-maps.

@perrygovier
Copy link
Contributor

perrygovier commented Aug 28, 2018

Hey @wf9a5m75, I'm not ignoring you, it has been less than a day. I think the negative tone is unnecessary. Let's try this again. Your plugin is great and I have no opinion on whether it's good or bad that it's in a different repo. We were focused on plugins inside this repo while we were scrambling to get these beta docs out. That script you linked to is for the stable docs here. The new beta native docs are generated in this file.

I'm currently working on a different project but can add a link to your separate repo when I work on the docs later this week. I was hoping I could write a script to inspect it and automatically generate a docs page like the others, but a link would work for now.

@wf9a5m75
Copy link
Contributor Author

Thank you for your replying, I understand that.
I didn't know the ionic-docs repo. That's why I ignored first two days.

I was hoping I could write a script to inspect it and automatically generate a docs page like the others, but a link would work for now.

Creating a doc page is difficult from different repo, and I think the general doc pages are less information.
There are already doc pages, and I will put latest information to here.
https://github.com/ionic-team/ionic-native-google-maps/blob/master/documents/README.md

Could you add a link to this page when you are available? I just want to ask you only this one.
Thanks.

@perrygovier
Copy link
Contributor

Hey @wf9a5m75, adding this should be very quick and easy, but the larger build script needs some updates to get it to take effect on the website. I can't do it today, but it should be soon.

@wf9a5m75
Copy link
Contributor Author

Okay, effecting a link in next time update is fine. Thanks for your help.

@wf9a5m75
Copy link
Contributor Author

Great! Thank you!

@wf9a5m75
Copy link
Contributor Author

@perrygovier Could you add a link to Google Maps repo URL in the new list? https://ionicframework.com/docs/native

@perrygovier
Copy link
Contributor

Ah, the docs were refactored and the person who took it over didn't know about this special case. I've brought him up to speed.

@wf9a5m75
Copy link
Contributor Author

Then when will you (he) add Google Maps link to the list page? I waited 4 days, but no updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants