New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GoogleMaps to the v4 api list page #2658
Comments
@mlynch ping |
Hey @wf9a5m75, the maintainer of that plugin decided to build their plugin in an entirely different repo, so our documentation scripts don't see it. It's on our todo list to add some special scripts to make sure it's included. For the beta launch we were more focused on the plugins in this repo. |
The reason of this is the ionic team does not maintenance the wrapper plugin well. I don't ask any difficult thing. I just ask Is this super difficult? |
I guess you just modify this script. Should I send a pull request if difficult work? |
@perrygovier Any comments? |
Ok, if Ionic team does not help me, I won't help you. Starting from now until you work, I will decline any issues for the ionic-native/google-maps. |
Hey @wf9a5m75, I'm not ignoring you, it has been less than a day. I think the negative tone is unnecessary. Let's try this again. Your plugin is great and I have no opinion on whether it's good or bad that it's in a different repo. We were focused on plugins inside this repo while we were scrambling to get these beta docs out. That script you linked to is for the stable docs here. The new beta native docs are generated in this file. I'm currently working on a different project but can add a link to your separate repo when I work on the docs later this week. I was hoping I could write a script to inspect it and automatically generate a docs page like the others, but a link would work for now. |
Thank you for your replying, I understand that.
Creating a doc page is difficult from different repo, and I think the general doc pages are less information. Could you add a link to this page when you are available? I just want to ask you only this one. |
Hey @wf9a5m75, adding this should be very quick and easy, but the larger build script needs some updates to get it to take effect on the website. I can't do it today, but it should be soon. |
Okay, effecting a link in next time update is fine. Thanks for your help. |
Great! Thank you! |
@perrygovier Could you add a link to Google Maps repo URL in the new list? https://ionicframework.com/docs/native |
Ah, the docs were refactored and the person who took it over didn't know about this special case. I've brought him up to speed. |
Then when will you (he) add Google Maps link to the list page? I waited 4 days, but no updated. |
Please add @ionic-native/google-maps to https://beta.ionicframework.com/docs/native page.
@ionic-native/google-maps v5.0.0-beta works on ionic v4
The text was updated successfully, but these errors were encountered: