Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dfu-update): add DfuUpdate Plugin Wrapper #3514

Merged
merged 4 commits into from Nov 19, 2020
Merged

feat(dfu-update): add DfuUpdate Plugin Wrapper #3514

merged 4 commits into from Nov 19, 2020

Conversation

EinfachHans
Copy link
Contributor

@EinfachHans EinfachHans commented Aug 18, 2020

I created this PR as Wrapper for my Plugin DfuUpdate which uses Nordic Semiconductor's Device Firmware Update (DFU) service to update a Bluetooth LE device.

*
* @usage
* ```typescript
* import { DfuUpdate } from '@ionic-native/dfu-update';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add /ngx to the import

@EinfachHans
Copy link
Contributor Author

@danielsogl done

@ghost
Copy link

ghost commented Oct 16, 2020

shouldn't this be named in a way that specifics that it's for nordic devices only?

@danielsogl danielsogl self-assigned this Nov 19, 2020
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Nov 19, 2020
@danielsogl danielsogl merged commit 07d7ace into danielsogl:master Nov 19, 2020
@EinfachHans EinfachHans deleted the dfuupdate branch November 19, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants