Skip to content
This repository has been archived by the owner on Apr 2, 2018. It is now read-only.

Social login not "remembering" user credentials #23

Closed
sagivf opened this issue Jul 16, 2016 · 11 comments
Closed

Social login not "remembering" user credentials #23

sagivf opened this issue Jul 16, 2016 · 11 comments
Assignees

Comments

@sagivf
Copy link

sagivf commented Jul 16, 2016

After login out and in - you have re login to Facebook every time.

When I used http://ionicframework.com/docs/v2/native/facebook/ in a different app, it remembered the user credentials when login into Facebook, and the user doesn't have to go trough the login again (lots of users doesn't remember their credentials).

Not sure this can be achieved in the current constellation, maybe through some sort of api integration with the app developer.

@imhoffd
Copy link
Contributor

imhoffd commented Aug 4, 2016

@sagivf The Facebook dialog opens when auth.login('facebook') is called and the user is prompted to login every time. We're specifying reauthenticate for auth_type (see https://developers.facebook.com/docs/facebook-login/reauthentication). I'm not sure if we want to remember the user credentials by default, but I think it'd be smart to have the option for it.

Thoughts?

@imhoffd imhoffd self-assigned this Aug 4, 2016
@sagivf
Copy link
Author

sagivf commented Aug 4, 2016

Not sure a fully get this, but in the browser if you are signed in to facebook, any site using facebook OAuth will not require you log in to facebook. If you logout on any window only then will you need to login. This behaviour is the same when you use the native facebook login.

Also it says that the reauthentication is meant for cases where there is sensative data that needs an extra password validation -

image

image

@imhoffd
Copy link
Contributor

imhoffd commented Aug 4, 2016

@sagivf Okay, it makes sense to remember them and not force a re-login.

@imhoffd imhoffd added this to the @ionic/cloud beta release milestone Aug 13, 2016
@imhoffd
Copy link
Contributor

imhoffd commented Aug 13, 2016

I will do this for the milestone.

@sagivf sagivf changed the title Facebook login not "remembering" user credentials Social login not "remembering" user credentials Aug 20, 2016
@sagivf
Copy link
Author

sagivf commented Aug 20, 2016

@dwieeb The more I think about it the more I think this is important.
Users that have to insert there credentials might easily prefer to just use a regular signup or forget about the app altogether. Ideally using the native facebook app would be best but this probably not possible so at least sharing the browsers mechanism would be good.

Haven't fully investigated the technical details but this is defiantly important.

@SteveKennedy
Copy link

SteveKennedy commented Aug 21, 2016

I agree about this importance. I think I'm running into this issue. I'm developing a new app using Ionic 2, TypeScript 2, and Angular 2. When calling auth.login("facebook") - it forces a new login screen. Same for Google.

@olivercodes
Copy link
Contributor

@sagivf @SteveKennedy Please note I'm working on a fix for this and should have it updated shortly!

@imhoffd
Copy link
Contributor

imhoffd commented Aug 22, 2016

@sagivf @SteveKennedy It's definitely possible for us to provide a login method with the native Facebook app (with the cordova-plugin-facebook4 plugin of course) for Ionic Authentication. We just went the InAppBrowser route because it was faster/easier/whatever.

I'll think on this.

@SteveKennedy
Copy link

Thanks for your hard work. This is all new to me, so I don't entirely know what I'm saying. :)

I don't entirely know the difference between the user experiences - between using inAppBrowser vs the Cordova plugin. Ideally, I would want something seamlessly native looking. I assume that's with the facebook4 plugin.

The inAppBrowser isn't a bad experience. Except that it asks me to login to FB/Google with credentials, even though the rest of my phone apps somehow don't need to ask for those credentials. They somehow use credentials from the phone/apps, without having to ask for them.

@imhoffd
Copy link
Contributor

imhoffd commented Aug 22, 2016

@SteveKennedy Yup, the native experience would come with that plugin, just like the rest of the apps with social logins.

@sagivf @SteveKennedy We're going to try to implement Facebook authentication using cordova-plugin-facebook4 for this milestone. This should give us what we want.

Now, no more scope creep! 😆

@imhoffd
Copy link
Contributor

imhoffd commented Aug 26, 2016

So we're actually going to go live with the current InAppBrowser implementation, but we have a milestone for native social login in the Cloud Client that @Devnetics and I will be putting together in the coming weeks, hopefully.

@imhoffd imhoffd closed this as completed Aug 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants