fix(android): Use arm64 architecture on emulator creation from M1 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
giralte-ionic,
IT-MikeS,
ItsChaceD and
theproducer
giralte-ionic
approved these changes
Sep 22, 2022
IT-MikeS
approved these changes
Sep 22, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
## [1.7.1](v1.7.0...v1.7.1) (2022-09-23) ### Bug Fixes * **android:** Use arm64 architecture on emulator creation from M1 ([#258](#258)) ([a6501c4](a6501c4))
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no emulator for the SDK, native-run will try to create a new one, but on M1 macs it fails to create new emulators because the emulator files we provide have the architecture hardcoded to x86.
This patch will check the machine architecture and if it's arm64 it will overwrite the x86 values with arm64, fixing the emulator creation.