Feat console port forwarding #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
reviewed
May 30, 2019
src/android/index.ts
Outdated
| @@ -10,11 +10,12 @@ export async function run(args: string[]) { | |||
| return; | |||
| } | |||
|
|
|||
| let cmd: any; | |||
src/android/run.ts
Outdated
|
|
||
| if (forwardedPorts && forwardedPorts.length > 0) { | ||
| forwardedPorts.forEach((port: string) => { | ||
| const [ device, host ] = port.split(':'); |
There was a problem hiding this comment.
Indentation looks off here, does tslint not catch this?
src/android/run.ts
Outdated
|
|
||
| if (forwardedPorts && forwardedPorts.length > 0) { | ||
| forwardedPorts.forEach((port: string) => { | ||
| const [ device, host ] = port.split(':'); | ||
|
|
||
| if (!device || !host) { | ||
| throw new CLIException('Invalid --forward value: expecting <device port:host port>, e.g. 8080:8080'); |
There was a problem hiding this comment.
Now that --forward can take multiple values, it may be useful to print which values were the bad ones.
src/android/run.ts
Outdated
| @@ -37,8 +42,11 @@ export async function run(args: string[]) { | |||
| await waitForBoot(sdk, device); | |||
|
|
|||
| if (ports) { | |||
| await forwardPorts(sdk, device, ports); | |||
| log(`Forwarded device port ${ports.device} to host port ${ports.host}\n`); | |||
| ports.map(async (port: Ports) => { | |||
There was a problem hiding this comment.
You should await Promise.all(ports.map( ... )) so the ports are forwarded before installing the apk.
src/android/run.ts
Outdated
| @@ -50,7 +58,9 @@ export async function run(args: string[]) { | |||
|
|
|||
| onBeforeExit(async () => { | |||
| if (ports) { | |||
| await unforwardPorts(sdk, device, ports); | |||
| ports.map(async (port: Ports) => { | |||
There was a problem hiding this comment.
You should await Promise.all(ports.map( ... )) or the process may exit before the ports are freed
src/utils/cli.ts
Outdated
| export function getOptionsValue(args: string[], arg: string): string[] { | ||
| const returnVal: string[] = []; | ||
| args.map((entry: string, idx: number) => { | ||
| if (entry === arg) { |
Ionitron
added a commit
that referenced
this pull request
May 30, 2019
# [0.2.0](v0.1.2...v0.2.0) (2019-05-30) ### Bug Fixes * **ios:** log iOS --list errors, but still print ([e516a83](e516a83)) * **ios:** print more helpful error if app path doesn't exist ([49819b0](49819b0)) ### Features * **android:** better error messaging ([0cfa51a](0cfa51a)) * **android:** have --forward accept multiple values ([#26](#26)) ([7844ea4](7844ea4))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support or multiple port forwarding.
Needed for ionic-team/ionic-cli#3995